Support Redis-rb v5 #314
Merged
Support Redis-rb v5 #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hieuk09
force-pushed
the
feature/upgrade-to-redis-5
branch
2 times, most recently
from
a5662c7 to
987bc93
Compare
hieuk09
commented
Nov 24, 2024
| assert_valid_integer(seconds) | ||
| seconds = Integer(seconds) |
There was a problem hiding this comment.
These changes mimic how redis-rb handles the number conversion
Comment on lines
-160
to
+161
| raise Redis::CommandError, 'BUSYKEY Target key name already exists.' | ||
| raise Error.command_error('BUSYKEY Target key name already exists.', self) |
There was a problem hiding this comment.
This change is tested only with MockRedis and not with the multiplexer.
Comment on lines
+38
to
+39
| rescue Redis::CommandError => e | ||
| raise Error.command_error(e.message, self) |
There was a problem hiding this comment.
I can't access connection URL inside Stream object so I need to rescue the error & wrap it here
hieuk09
force-pushed
the
feature/upgrade-to-redis-5
branch
from
987bc93 to
8a974a4
Compare
hieuk09
force-pushed
the
feature/upgrade-to-redis-5
branch
from
8a974a4 to
9477e66
Compare
|
Phenomenal effort—thank you. If after release bugs are found related to this change, I will redirect any issues opened to you for the time being (unless trivial to address myself). Thanks again. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix #281. This PR was also tested using the test suite of our service.
There are a few decisions I made regarding this PR, please let me know if it's not appropriate:
MockRedis::Errormodule which decorateRedis::CommandErrorand related errors with the connection URLRedis::CommandErrorwith the new module wrapperexists_returns_integeris removedassert_typeis added to validate the arguments. Currently it doesn't look very clean, so any improvements would be great.sadd,sremnow support multiple argumentsmultinow needs to call with a block anddiscard/execcannot be called outside that block anymore